Patches saved shortly before power off aren't stored

#1

Description

See the subject line.

How to reproduce

  1. Change a pedalboard
  2. Hit the save button
  3. Power off the device once the store bar has finished
  4. Power on the device. Changes sometimes aren’t stored

Expected/suggested solution

Use fsync()/sync after writing a pedalboard

or (to probably catch some more instances of this problem):

echo 100 > /proc/sys/vm/dirty_expire_centisecs echo 100 > /proc/sys/vm/dirty_writeback_centisecs

Additional information

I’m on 1.4 RC2

Some background info / additional reading: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/317781/comments/45

#2

Note that the file systems are mounted with the sync option on the mod, but it seems the sync options is not supported for ext4 file systems.

#3

Bump, because it’s important :slight_smile:

#4

Maybe you have better luck at https://github.com/moddevices/mod-duo-issues/issues

#5

We have plans for handling this, likely for v1.6.
It’s not just plugin presets that need it, lots of other small things too (pedalboards, plugins, user configs).
Preferably we also keep the old file when saving over an existing one, so that it can serve as a backup in case things go wrong.