But about the
css/js/image files, do I need to update both repo or just the mod-lv2-data?
@jon I found a bug: the SwitchTrigger4 doesn’t save correctly the state: if I save the pedalboard, change the current pedalboard and go back, the active state of this plugin is probably wrong. The reproduction steps are presented into SwitchTrigger4 - bug - MOD Devices
I don’t understood what happened. I noticed that, initially (i.e., after add a instance of the plugin on the pedalboard), the persisted state of all channels (
channel4) of the plugins is saved as zero. But after press a footswich, it is saved as
1, then the active channel will be the highest channel: https://github.com/moddevices/mod-utilities/blob/master/SwitchTrigger4/src/switchtrigger4.cpp#L124-L142
I don’t know why is saved as
1, because after press the footswitch for enable it, the code disabled it (https://github.com/moddevices/mod-utilities/blob/master/SwitchTrigger4/src/switchtrigger4.cpp#L124-L142), then, in my understanding, the values should be as
one. It is apparently a bug of the platform, not exactly of this plugin.
Then we have two bugs:
- The persistence of toggle state
- The persistence of the SwitchTrigger4 plugin state
To solve specifically the plugin bug, I’m thinking to create a “select” input controller (
lv2:enumeration), that will save the last selected channel. A plus of this approach is that will be also possible to assign footswitch(es) to change the current channel (just like the SwitchBox 1-2, but for 4 outputs )
Note that I will not remove the four channels input controls, I will just add the lv2:enumeration that will not be directly accessible over the mod-ui pedalboard view but will be accessible over the parameter settings view ().
What you think about it, guys?